Fixing rare case for summaries without non-quantile label#22
Open
theZiz wants to merge 1 commit into
Open
Conversation
It noticed a special case in Prometheus looking like this
```
# TYPE my_fancy_metric summary
my_fancy_metric_count 23
my_fancy_metric_sum 42
my_fancy_metric{quantile="0.5"} 0.2
my_fancy_metric{quantile="0.9"} 0.1
my_fancy_metric{quantile="0.95"} 0.05
my_fancy_metric{quantile="0.99"} 0.02
```
results in a run time error as first the `count` and `sum` are handled which creates the `flattened` struct. Because of this the line `flattened[groupName] = {}` is not executed later (as only for `flattened` is checked, not for `flattened[groupName] = {}`) although it us accessed right after.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It noticed a special case in Prometheus looking like this
results in a run time error as first the
countandsumare handled which creates theflattenedstruct. Because of this the lineflattened[groupName] = {}is not executed later (as only forflattenedis checked, not forflattened[groupName] = {}) although it us accessed right after.