-
Notifications
You must be signed in to change notification settings - Fork 2
chore: Upgrade to Expo SDK 55 #40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sidorchukandrew
wants to merge
11
commits into
main
Choose a base branch
from
as/expo-55-upgrade
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
e01393f
chore: upgrade to Expo 55
sidorchukandrew 69f7b26
docs: update minimum Expo SDK to 55
sidorchukandrew 378c02a
chore: install expo ui and update packages
sidorchukandrew f9ceba9
chore: use `ExpoUIView` when registering native views
sidorchukandrew 42929b4
chore: inherit `UIBaseViewProps` for view props
sidorchukandrew ac85e16
chore: stop using `WithHostingView`
sidorchukandrew 39e2581
chore: stop using `AutoSizingStack`
sidorchukandrew 80cba11
chore: add dependency on `ExpoUI` in podspec
sidorchukandrew 118ff86
chore: wrap components in `<Host />`
sidorchukandrew 78eb196
chore: add fixed size modifier
sidorchukandrew ffe00f7
test: add mocks to make tests pass
sidorchukandrew File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,10 @@ | ||
| import ExpoModulesCore | ||
| import ExpoUI | ||
|
|
||
| public class RNBibleReaderViewModule: Module { | ||
| public func definition() -> ModuleDefinition { | ||
| Name("BibleReaderView") | ||
|
|
||
| View(YVPBibleReaderView.self) | ||
| ExpoUIView(YVPBibleReaderView.self) | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,10 @@ | ||
| import ExpoModulesCore | ||
| import ExpoUI | ||
|
|
||
| public class RNBibleTextViewModule: Module { | ||
| public func definition() -> ModuleDefinition { | ||
| Name("BibleTextView") | ||
|
|
||
| View(YVPBibleTextView.self) | ||
| ExpoUIView(YVPBibleTextView.self) | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,10 @@ | ||
| import ExpoModulesCore | ||
| import ExpoUI | ||
|
|
||
| public class RNBibleWidgetViewModule: Module { | ||
| public func definition() -> ModuleDefinition { | ||
| Name("BibleWidgetView") | ||
|
|
||
| View(YVPBibleWidgetView.self) | ||
| ExpoUIView(YVPBibleWidgetView.self) | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,10 @@ | ||
| import ExpoModulesCore | ||
| import ExpoUI | ||
|
|
||
| public class RNSignInWithYouVersionButtonModule: Module { | ||
| public func definition() -> ModuleDefinition { | ||
| Name("SignInWithYouVersionButton") | ||
|
|
||
| View(YVPSignInWithYouVersionButton.self) | ||
| ExpoUIView(YVPSignInWithYouVersionButton.self) | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,10 @@ | ||
| import ExpoModulesCore | ||
| import ExpoUI | ||
|
|
||
| public class RNVotdViewModule: Module { | ||
| public func definition() -> ModuleDefinition { | ||
| Name("VotdView") | ||
|
|
||
| View(YVPVotdView.self) | ||
| ExpoUIView(YVPVotdView.self) | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpick (non-blocking): We now want to default to Bible Version 3034, which is the Berean Standard Bible
Here's the heart behind it: https://www.notion.so/yvproduct/Default-English-language-Bible-Version-to-Berean-Standard-Bible-305f1f2d1b92809d85ddeb473403674d?source=copy_link