Add encoding parameter to profile path detection#470
Open
vadim-zyamalov wants to merge 1 commit intoyokoffing:mainfrom
Open
Add encoding parameter to profile path detection#470vadim-zyamalov wants to merge 1 commit intoyokoffing:mainfrom
vadim-zyamalov wants to merge 1 commit intoyokoffing:mainfrom
Conversation
Owner
|
@Denperidge I think this is okay. Any objections? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems that new profile system of Firefox allows non-ascii symbols in the profile folder name.
This tiny PR forces
install.pyto use UTF8 for the folder name.PS: this is a "copy" of my previous PR closed by myself. Too many personal commits leaked in previous PR so I had to clean and rearrange my fork.