Skip to content

Fix the distribution of resolvers on an uninitialised machine#122

Open
tadeas-hejnic wants to merge 2 commits into
developfrom
121-yn-0715-usd-resolver-is-not-distributing
Open

Fix the distribution of resolvers on an uninitialised machine#122
tadeas-hejnic wants to merge 2 commits into
developfrom
121-yn-0715-usd-resolver-is-not-distributing

Conversation

@tadeas-hejnic
Copy link
Copy Markdown
Contributor

Changelog Description

This pull request refactors how the addon metadata JSON file is handled to ensure it is always present and initialized correctly. The main improvement is the introduction of a utility function to centralize and simplify the creation and reading of this metadata file.

Testing notes:

  1. start with blank setup (delete downloaded resolvers)
  2. launch the DCC
  3. test the resolver
  4. test it also on a farm

@tadeas-hejnic tadeas-hejnic linked an issue May 5, 2026 that may be closed by this pull request
@tadeas-hejnic tadeas-hejnic self-assigned this May 5, 2026
@tadeas-hejnic tadeas-hejnic added type: bug Something isn't working sponsored This is directly sponsored by a client or community member labels May 5, 2026
@tadeas-hejnic tadeas-hejnic changed the title Fix the resolver distribution on uninitialized machine Fix the distribution of resolvers on an uninitialised machine May 5, 2026
Copy link
Copy Markdown
Member

@BigRoy BigRoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Only confusing thing is that function name ensure_addon_data_json you wouldn't really expect it to return a dict? Should it maybe just return {} and not make the file at all if it does not exist. Especially because ayon_usd_addon_first_init_utc does not seem to be used anywhere?

So maybe it should be get_addon_json_data?

Copy link
Copy Markdown
Member

@MustafaJafar MustafaJafar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I gave it a test locally on Houdini and Maya. It may take me a little longer to test it on farm.
I didn't look into the code or changes but from user perspective. it works as usual.

@tadeas-hejnic
Copy link
Copy Markdown
Contributor Author

LGTM

Only confusing thing is that function name ensure_addon_data_json you wouldn't really expect it to return a dict? Should it maybe just return {} and not make the file at all if it does not exist. Especially because ayon_usd_addon_first_init_utc does not seem to be used anywhere?

So maybe it should be get_addon_json_data?

I have separated the ensure_addon_data_json to create_addon_data_json_file and get_addon_data_json, so now it has single responsibility and clear names.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

sponsored This is directly sponsored by a client or community member type: bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

YN-0715: USD resolver is not distributing

4 participants