FTP: Code brushup#80
Merged
Merged
Conversation
iLLiCiTiT
added
the
type: enhancement
kalisp
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Description
Fix formatting and enhance conditions.
Additional review information
Fixed formatting ruff is complaining about (not sure how it got into codebase?). Removed variable
status_valbefore loop as it is defined within the loop. Define better default value oflast_tickto avoid complex condition.NOTE: I did find out that the ftp provider is creating threads that are not joined which might lead to dangling processes that should be probably handled in a better way. Will create an issue.
Testing notes: