EntityData: Better deepcopy and error handling #293
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iLLiCiTiT
changed the title
BigRoy
reviewed
Dec 9, 2025
Co-authored-by: Roy Nieterau <roy_nieterau@hotmail.com>
BigRoy
approved these changes
Dec 9, 2025
Contributor
BigRoy
left a comment
BigRoy
left a comment
There was a problem hiding this comment.
@Thierry-Submarine any chance you can give this a try?
iLLiCiTiT
changed the title
iLLiCiTiT
deleted the
enhancement/288-recursive-loop-in-entitydata-class
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Description
Use deepcopy of key and value instead of full object in
EntityData.Additional review information
This might help to prevent recursion error, and if not then the error might help to reveal what the issue is.
Testing notes:
Should help to resolve #288