Transfer: Add retry options to upload and download #292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BigRoy
approved these changes
Dec 8, 2025
Contributor
BigRoy
left a comment
BigRoy
left a comment
There was a problem hiding this comment.
Not sure how to best test, but code makes sense.
iLLiCiTiT
deleted the
enhancement/291-yn-0247-server-timeouts-on-streamed-uploads
branch
iLLiCiTiT
commented
Dec 9, 2025
| """ | ||
| url = self._endpoint_to_url(endpoint) | ||
| url = self._endpoint_to_url(endpoint, use_rest=False) |
Member
Author
There was a problem hiding this comment.
This was changed back to original value in develop after merge commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Description
Upload and download use retries if connection fails.
Additional review information
Added attempt to TransferProgress to track how many times it tried. Download can continue where ended up. Fixed
_endpoint_to_urlto use base url instead of graphql endpoint and download/upload functions do request endpoint without/api.Testing notes:
Resolves #291