Skip to content

refactor(menus): replace logging module with ayon Logger#73

Open
philippe-ynput wants to merge 1 commit into
developfrom
use-ayon-logger
Open

refactor(menus): replace logging module with ayon Logger#73
philippe-ynput wants to merge 1 commit into
developfrom
use-ayon-logger

Conversation

@philippe-ynput
Copy link
Copy Markdown
Contributor

Changelog Description

  • Replace stdlib logging with ayon_core.lib.Logger for consistency with the rest of the AYON pipeline tooling
  • Add # type: ignore comments to third-party imports lacking stubs
  • Fix typo: "controler" -> "controller" in comments
  • Replace bare print calls with log.info for uniform log handling

Testing notes:

  1. start with this step
  2. follow this step

- Replace stdlib `logging` with `ayon_core.lib.Logger` for consistency
  with the rest of the AYON pipeline tooling
- Add `# type: ignore` comments to third-party imports lacking stubs
- Fix typo: "controler" -> "controller" in comments
- Replace bare `print` calls with `log.info` for uniform log handling

Signed-off-by: philippe-ynput <philippe@ynput.io>
@philippe-ynput philippe-ynput self-assigned this Feb 25, 2026
@philippe-ynput philippe-ynput added the type: enhancement Improvement of existing functionality or minor addition label Feb 25, 2026
Copy link
Copy Markdown
Member

@kalisp kalisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sys.path[:] = rv_paths + non_rv_paths

import PyOpenColorIO # noqa
import PyOpenColorIO # type: ignore # noqa
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this essentially what # noqa is supposed to be doing too? 🤔 @antirotor the master of linters can probably tell how we should clean this up.

Copy link
Copy Markdown
Member

@BigRoy BigRoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: enhancement Improvement of existing functionality or minor addition

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants