refactor(menus): replace logging module with ayon Logger#73
Open
philippe-ynput wants to merge 1 commit into
Open
refactor(menus): replace logging module with ayon Logger#73philippe-ynput wants to merge 1 commit into
philippe-ynput wants to merge 1 commit into
Conversation
- Replace stdlib `logging` with `ayon_core.lib.Logger` for consistency with the rest of the AYON pipeline tooling - Add `# type: ignore` comments to third-party imports lacking stubs - Fix typo: "controler" -> "controller" in comments - Replace bare `print` calls with `log.info` for uniform log handling Signed-off-by: philippe-ynput <philippe@ynput.io>
BigRoy
reviewed
Feb 27, 2026
| sys.path[:] = rv_paths + non_rv_paths | ||
|
|
||
| import PyOpenColorIO # noqa | ||
| import PyOpenColorIO # type: ignore # noqa |
Member
There was a problem hiding this comment.
Isn't this essentially what # noqa is supposed to be doing too? 🤔 @antirotor the master of linters can probably tell how we should clean this up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Description
loggingwithayon_core.lib.Loggerfor consistency with the rest of the AYON pipeline tooling# type: ignorecomments to third-party imports lacking stubsprintcalls withlog.infofor uniform log handlingTesting notes: