Version handles calculated based on context handles#254
Open
splidje wants to merge 2 commits into
Open
Conversation
…n context handles. Handle set for plate product type as well as render.
BigRoy
added
type: enhancement
rdelillo
requested changes
May 11, 2026
| handle_end = instance.context.data["handleEnd"] | ||
| first_frame, last_frame = self._get_frame_range_data(instance) | ||
| handle_start = max(0, root_first_frame + context_handle_start - first_frame) | ||
| handle_end = max(0, last_frame - (root_last_frame - context_handle_end)) |
Contributor
There was a problem hiding this comment.
I'm not sure I understand where root_first_frame and context_handle_start come from.
Also do you mind to detail a bit more on why you need this new logic replacing instance.context_data please ?
…irst/last_frame and context_handle_start/end
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Description
Version handles calculated based on context handles. Handles set for plate product type as well as render.