Load Backdrop: Avoid scene connections breaking to selected nodes when loading backdrop#251
Open
BigRoy wants to merge 3 commits into
Open
Load Backdrop: Avoid scene connections breaking to selected nodes when loading backdrop#251BigRoy wants to merge 3 commits into
BigRoy wants to merge 3 commits into
Conversation
…ng automatically connected to the input of the NoOp (default nuke behavior) + move the logic inside the maintained selection contextlib so that we do actually maintain the users selection as intended. Also, remove some redundant `reset_selection` calls before explicitly deleting a node (selection should not affect it.)
BigRoy
added
type: bug
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes Nuke node graph connection breakage when loading a backdrop/placeholder while nodes are selected, by ensuring selection is properly preserved and cleared at the right moments to prevent Nuke’s auto-connect behavior.
Changes:
- Wrap mouse-position probing (temporary NoOp creation) inside
maintained_selection()so the user’s selection is actually restored afterward. - Clear selection before creating the temporary NoOp to avoid unintended automatic connections to selected nodes.
- Remove redundant
reset_selection()calls before explicitnuke.delete(node)operations.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
moonyuet
approved these changes
May 1, 2026
Member
moonyuet
left a comment
moonyuet
left a comment
There was a problem hiding this comment.
Works with testing with import backdrop and load placeholder in Nuke 16.0
…nputs (returns empty list)
BigRoy
commented
May 1, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jakubjezek001
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Description
Fixes issue where the scene may be losing existing connections if loading backdrop. The easiest way to reproduce is to select all nodes in the graph, load the placeholder. Previously it'd essentially break your scene.
Additional review information
Reset selection before creating the NoOp to avoid the selection getting automatically connected to the input of the NoOp (default nuke behavior) + move the logic inside the maintained selection contextlib so that we do actually maintain the users selection as intended. Also, remove some redundant
reset_selectioncalls before explicitly deleting a node (selection should not affect it.)Testing notes: