fix: only copy attributes if they exist#249
Merged
jakubjezek001 merged 1 commit intoMay 5, 2026
Merged
Conversation
BigRoy
approved these changes
Apr 28, 2026
Member
BigRoy
left a comment
There was a problem hiding this comment.
Seems like a decent fix. At the same time, I personally don't see why we'd want to imprint this data to begin with. I feel like we're better off at some point removing these from being imprinted at all. @jakubjezek001 thoughts?
jakubjezek001
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Description
Only copy
fpsandsourceif they exists onversion_attributesAdditional review information
Its not uncommon for us to ingest nukenodes via the traypublisher (eg.: as part of deliveries from third party vendors)
Those products do not have an
fpsattribute and don't really need one either.Testing notes:
nuke.nodeCopy("/mnt/d/work/nodes.nk")nukenodesproduct typenodes.nkfrom trayPublisherexample tray publisher config: