Experimental: switch logging to loguru#291
Open
antirotor wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Description
Loguru is a library which aims to bring enjoyable logging in Python. AYON was already customizing logging to handle some colorization and contextualization but using loguru will allow to do it with more consistency and in standard way. It also simplify connecting logging facility to some telemetry/log aggregation system.
Additional info
This is still in proof-of-concept phase. Formatting in set now in ayon-launcher and propagated down the line but it can be changed. Logs are processed by rich and you can add various markup to the log messages to format it further:
It also has its automatic highlighting (that might need some tweaks) that can be disabled and customized.
Rich itself has some very useful features not related to logging, like very nice pretty printing, etc.
It produces output like this now:

(notice wrong highlighting on timing info that needs to be fixed)
Stuff to add
Note
To test it, you'll need also PR from ayon-core