feat: Use SubmissionContext pattern for efficient scene queries#13
Open
leon-li-inspire wants to merge 2 commits into
Open
feat: Use SubmissionContext pattern for efficient scene queries#13leon-li-inspire wants to merge 2 commits into
leon-li-inspire wants to merge 2 commits into
Conversation
…ries Use create_submission_context() from deadline-cloud-for-maya to compute scene data once and share it across get_job_template_for_submission() and get_parameter_values_for_submission() calls, avoiding redundant _set_render_layer_data() invocations. Requires: aws-deadline/deadline-cloud-for-maya with SubmissionContext support. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Member
|
Thanks, LGTM, will do it once the linked PR is merged and synced. |
antirotor
added
enhancement
Resolve conflict in collect_deadline_cloud_job_data.py by integrating the SubmissionContext pattern with the new submitter_bridge abstraction. The bridge now exposes create_submission_context as an optional callable, allowing hosts that support it (Maya) to share computed scene data across template and parameter calls.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
create_submission_context()fromdeadline-cloud-for-mayato compute expensive Maya scene data (render layers, cameras) once and share it across multiple submission function calls_set_render_layer_data()invocations in both the creator and collector pluginsChanges
plugins/create/maya/create_job.py: Creates a sharedSubmissionContextand passescontext=to bothget_job_template_for_submission()andget_parameter_values_for_submission()plugins/publish/collect_deadline_cloud_job_data.py: Same pattern — creates context once, passes to_build_job_template()andget_parameter_values_for_submission()Test plan
create_submission_contextis importable:from deadline.maya_submitter.maya_render_submitter import create_submission_context🤖 Generated with Claude Code