perf(loader/ui): optimize inspector refresh during drag selection#1849
Merged
philippe-ynput merged 6 commits intoMay 28, 2026
Merged
Conversation
Prevent unnecessary refreshes while mouse is pressed during drag selection in the ReviewInspector. The inspector now only updates when the selection is finalized (on mouse release) rather than during the selection process. This reduces UI flickering and improves performance when selecting multiple items via drag in the review inspector panel. Signed-off-by: philippe-ynput <philippe@ynput.io>
philippe-ynput
added
the
type: enhancement
Signed-off-by: philippe-ynput <philippe@ynput.io>
Introduce a QTimer-based throttling mechanism in ReviewInspector to dynamically adjust update frequency during drag selection operations. The implementation measures the base update time during the first selection and scales the throttle interval proportionally to the number of selected items. This provides adaptive performance optimization while maintaining responsiveness during interactive selection operations. Timer is properly managed with start/stop calls during mouse press/release events to ensure clean resource handling. Signed-off-by: philippe-ynput <philippe@ynput.io>
Calculate update interval in milliseconds for more precise timing Sort thumbnail keys to reduce cache misses Remove debug print statement Signed-off-by: philippe-ynput <philippe@ynput.io>
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Optimizes ReviewInspector refresh behavior during drag selection to reduce UI flicker and improve responsiveness/performance.
Changes:
- Adds mouse press/release tracking via an event filter on the view viewport.
- Introduces a QTimer-driven throttling mechanism during drag interactions.
- Sorts thumbnail keys before loading to reduce cache misses.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| client/ayon_core/tools/loader/ui/review_inspector.py | Adds mouse tracking + throttled updates for drag selection; tweaks thumbnail loading order. |
| client/ayon_core/tools/loader/ui/_review_table.py | Removes a stray blank line. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Ensure inspector refreshes maintain at least 16ms interval to prevent excessive updates during rapid drag selection Signed-off-by: philippe-ynput <philippe@ynput.io>
github-project-automation
Bot
moved this from Review In Progress
to Done
in PR reviewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Description
Prevent unnecessary refreshes while mouse is pressed during drag selection in the ReviewInspector. The inspector now computes an expected refresh time to avoid filling the task queue with redundant update requests.
This reduces UI flickering and improves performance when selecting multiple items via drag in the review inspector panel.
Additional info
none
Testing notes: