Fix timing issue where unreleased badges could be obtained during badge loading#90
Open
zebraed wants to merge 1 commit intoynoproject:masterfrom
Open
Fix timing issue where unreleased badges could be obtained during badge loading#90zebraed wants to merge 1 commit intoynoproject:masterfrom
zebraed wants to merge 1 commit intoynoproject:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
badges loaded via
setBadges()had their Dev flag set to false untilupdateActiveBadgesAndConditions()was executedcould be obtained by players who met the conditions during this time
Changes
setBadges()beforeassigning to global variable
Fixes #88
Related ynoproject/forest-orb#709