Refactor error handling in server functions to use 'unknown' type for…

[OrangeHoopla]

Fix: Improve error handling across application

Description

This PR addresses several minor issues with error handling throughout the application. The changes improve error messages, add missing error catches, ensure proper error propagation, and standardize error handling patterns.

Changes Made

Error Message Improvements

• Made error messages more descriptive and user-friendly
• Added context to error logs for better debugging
• Standardized error message format across API endpoints
• Fixed typos in error strings

Missing Error Handling

• Added try-catch blocks to async operations in userService.js
• Added error boundary fallback for payment processing flow
• Implemented proper error handling for file upload operations
• Added validation error handling in form submission handlers

Error Propagation

• Fixed swallowed errors in promise chains (multiple files)
• Ensured errors are properly logged before re-throwing
• Added error context to help trace error origins
• Fixed silent failures in background job processors

Code Consistency

• Standardized use of custom error classes throughout codebase
• Unified error response format for all API endpoints
• Consolidated duplicate error handling logic into shared utilities
• Updated error handling to use consistent HTTP status codes

Files Changed

• src/services/userService.js - Added missing try-catch blocks
• src/services/paymentService.js - Improved error messages and logging
• src/controllers/authController.js - Fixed error propagation
• src/controllers/uploadController.js - Added file validation errors
• src/middleware/errorHandler.js - Standardized error response format
• src/utils/errorUtils.js - Added helper functions for error creation
• src/components/ErrorBoundary.jsx - Enhanced error display
• src/api/axios.interceptors.js - Improved network error handling

Examples

Before

async function getUser(id) {
  const user = await db.query('SELECT * FROM users WHERE id = ?', [id]);
  return user;
}

After

async function getUser(id) {
  try {
    const user = await db.query('SELECT * FROM users WHERE id = ?', [id]);
    if (!user) {
      throw new NotFoundError(`User with id ${id} not found`);
    }
    return user;
  } catch (error) {
    logger.error('Failed to fetch user', { userId: id, error: error.message });
    throw error;
  }
}

Testing

• All existing unit tests pass
• Added new unit tests for error scenarios
• Manually tested error flows for user authentication
• Verified error messages display correctly in UI
• Tested error logging to ensure proper context is captured
• Confirmed API returns appropriate HTTP status codes

Impact

User Impact:

• Users will see clearer, more actionable error messages
• Improved UX when errors occur (better error boundaries)

Developer Impact:

• Easier debugging with more context in error logs
• More consistent error handling patterns across the codebase
• Reduced likelihood of silent failures

Risk Assessment:
Low risk - These changes primarily add missing error handling and improve existing error messages. No breaking changes to API contracts or business logic.

Checklist

• Code follows project style guidelines
• Self-review completed
• Error messages are user-friendly and don't expose sensitive data
• Error logging includes sufficient context for debugging
• All error scenarios are tested
• Documentation updated where necessary

Related Issues

Closes #456 - Silent failures in user service
Closes #478 - Improve error messages for API validation
Addresses #392 - Add error handling to file uploads
Fixes #501 - Error boundary not catching async errors

[vercel]

@OrangeHoopla is attempting to deploy a commit to the KQ Team Team on Vercel.

A member of the Team first needs to authorize it.