This repository was archived by the owner on Jul 19, 2020. It is now read-only.
6-8 Styling page, Move Nested components page#87
Open
rlasjunies wants to merge 6 commits intoyewstack:masterfrom
Open
6-8 Styling page, Move Nested components page#87rlasjunies wants to merge 6 commits intoyewstack:masterfrom
rlasjunies wants to merge 6 commits intoyewstack:masterfrom
Conversation
rlasjunies
changed the title
rlasjunies
changed the title
src/SUMMARY.md
Outdated
| * [Nested component](concepts/components/nestedcomponents.md) | ||
| * [Refs](concepts/components/refs.md) | ||
| * [Styling](concepts/components/styling.md) | ||
| * [Life cycle](concepts/components/lifecycle.md) |
Contributor
There was a problem hiding this comment.
Stylistically, I think it's better for "life cycle" to be "lifecycle."
Author
There was a problem hiding this comment.
I ask myself about it and google it. Found more about "Life Cycle"
Anyway ... we are 2 having the same feeling => I change to 1 word
src/concepts/components/styling.md
Outdated
|
|
||
| ## Yew component does not support yet class attribute | ||
|
|
||
| So far Yew component does not support natively the `class` attribute. You can add the class attribute to your component: |
Contributor
There was a problem hiding this comment.
Gramatically this should read more along the lines of "At the moment Yew's components don't natively support the class attribute."
Author
There was a problem hiding this comment.
I understand that this limitation is now resolved with the 0.16 release with #1187
=> I remove the chapter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove of the CSS.md and add the Styling page
Move from html! the component page, rename it NestedComponents
Update summary