1/8 Create lifecycle page and review component introduction#82
1/8 Create lifecycle page and review component introduction#82rlasjunies wants to merge 7 commits intoyewstack:masterfrom
Conversation
|
@jstarry I am not so convinced ... I feel it heavy to read ... I still prefer the 1st proposal ;-p |
|
@jstarry @teymour-aldridge Doing so, you could see what it looks like. @jstarry
Optimizing rendering in the
|
|
This makes things a lot easier to follow.
… On 10 May 2020, at 17:57, Richard Lasjunies ***@***.***> wrote:
@jstarry <https://github.com/jstarry> @teymour-aldridge <https://github.com/teymour-aldridge>
Guys, as there is a lot of changes, it is complicate to review/follow.
To help, I am temporarly publishing the doc here <https://rlasjunies.github.io/yew_doc_branches_merged/>
Doing so, you could see what it looks like.
Let me know if this is something you would like.
@jstarry <https://github.com/jstarry>
We would appreciate your feedbacks on:
Component page <https://rlasjunies.github.io/yew_doc_branches_merged/concepts/components/index.html>: you were expecting something a bit more "rich" than the 1st proposal. Does it fit? ... or it's too complex
Properties <https://rlasjunies.github.io/yew_doc_branches_merged/concepts/components/properties.html>
In the example I add props field to the struct and props comparison in the change method. That complexify a bit.
Do you prefer that I move this code only in the
Optimizing rendering in the change method
BIG thanks to you Teymour!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#82 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AKFSTPJQMJLLQBBPYM77MSTRQ3MHVANCNFSM4M4I5EPQ>.
|
this is the 1st PR of several (should be 8)
@jstarry I did not, yet, review the content providing more interesting component. I will do it after the split of the PR