Skip to content

Added functionality to connect to a HTTP Basic Auth private registry#10

Open
robdewit wants to merge 1 commit into
yebinama:masterfrom
robdewit:master
Open

Added functionality to connect to a HTTP Basic Auth private registry#10
robdewit wants to merge 1 commit into
yebinama:masterfrom
robdewit:master

Conversation

@robdewit
Copy link
Copy Markdown

@robdewit robdewit commented Oct 5, 2018

I was having trouble connecting to v2 docker registry behind a proxy using HTTP Basic Auth. So this is my quick hack.

@yebinama
Copy link
Copy Markdown
Owner

yebinama commented Oct 8, 2018

Hello,
Thanks for the PR.
I have some questions about this functionality.

  • Since you don't pass a token to Clair, how did you configure it to access to the registry?
  • Instead of falling back to Http Basic Auth, maybe we could have 3 DockerRegistry Class: an abstract one, one for the Http Basic Auth authentication and one for the token authentication. The type of authentication should be set in the configuration file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants