Add support for specifying regionsVersion in subscription create/update commands#79
Open
softlion wants to merge 1 commit into
Open
Add support for specifying regionsVersion in subscription create/update commands#79softlion wants to merge 1 commit into
regionsVersion in subscription create/update commands#79softlion wants to merge 1 commit into
Conversation
…update commands - Fix build on windows
Owner
|
Thanks for this, @softlion. Your fix shipped in v0.9.85, extended to cover all eight subscriptions and one-time-products write commands (create, update, and their offer create/update), with Closing as released. You are credited in the changelog and release notes. |
Owner
|
Reopening — I shouldn't have closed your PR before you weighed in. The fix shipped on main (extended to all eight commands) and is credited to you, but I'll leave it to you to decide whether to close this or keep it open. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add support for specifying
regionsVersionin subscription create/update commandsAlso fix build on windows
Testing
pnpm test)pnpm lint)pnpm typecheck)Related
Fixes #78