Feat/challenge 2#3
Open
yasirelbouazzati wants to merge 20 commits into
Open
Conversation
tictools
requested changes
Jan 24, 2024
| const COUNTRIES = ["United Kingdom", "Italy", "France", "Portugal", "Greece"]; | ||
|
|
||
| const extractCountriesWithFiveCharactersOrFewer = function (countries) { | ||
| const countriesFilter = countries.filter((countrie) => { |
Collaborator
There was a problem hiding this comment.
Suggested change
| const countriesFilter = countries.filter((countrie) => { | |
| const countriesFilter = countries.filter((country) => { |
| return word.length >= 5; | ||
| }; | ||
|
|
||
| const longWord = words.filter((word) => filterLongWords(word)); |
Collaborator
There was a problem hiding this comment.
Suggested change
| const longWord = words.filter((word) => filterLongWords(word)); | |
| const longWord = words.filter(filterLongWords); |
| ]; | ||
|
|
||
| function getTotalVoters(voters) { | ||
| const totalVoters = voters.filter((voter) => voter.voted).length; |
Collaborator
There was a problem hiding this comment.
Nice solution! Are you able to explain what is it doing? 😉
| "version": "1.0.0", | ||
| "type": "module", | ||
| "main": "index.js", | ||
| "dependencies": { |
Collaborator
There was a problem hiding this comment.
We only need three devDependencies
"@babel/plugin-transform-modules-commonjs"
"jest"
"prettier"
FIX: remove all dependencies and install only required devDependencies.
| "prettier": "^3.2.2" | ||
| }, | ||
| "name": "09_javascript_array", | ||
| "description": "<figure style=\"text-align: center\"> <img src=\"https://upload.wikimedia.org/wikipedia/commons/thumb/6/6a/JavaScript-logo.png/640px-JavaScript-logo.png\" alt=\"DOM Tree\" width=\"100\" /> <figcaption>JavaScript</figcaption> </figure>", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
is almost complete