storage: wire new wavesdb engine capabilities into waveSpan#2
Merged
Conversation
wavesdb (the embedded LSM engine) gained 9 ondadb-backport features, already merged into wavesdb main which waveSpan builds against via the ../wavesdb replace directive. This wires the genuinely-additive ones into waveSpan's Go layers; the rest (RYOW fix, compaction filters, FIFO, ClearColumnFamily) are skipped because they duplicate or would break waveSpan's own distributed logic (documented inline). - Fail-stop poisoning: storage.ErrPoisoned + WavesdbStore.Poisoned(); the health monitor probes it in its poll loop, sheds writes via the existing DiskGate, sets a wavespan_storage_poisoned gauge, and fires OnPoison once -> graceful node exit (restart re-runs recovery). Latches until restart. - Single-process data-dir LOCK: map wavesdb.ErrLocked -> storage.ErrLocked with an actionable startup message; node refuses to start when the dir is already held. - Per-level compression: EngineOptions.CompressionPerLevel + a new storage.engine.compressionPerLevel CSV tunable; reference.yaml regenerated. - Bulk ingestion: SortedIngester capability + an ingestion fast-path in the logical restore write path (reshard / MemStore fall back to Batch). - Per-CF engine stats: an EngineStatsCollector exposing five wavespan_engine_* Prometheus series (point reads, SST probes, bloom skips, memtable entries, approx len), registered on the node. Also fixes a latent bug this surfaced: empty-string tunable defaults rendered as YAML null in the reference generator (reference.go now quotes them). Tests cover each workstream plus an end-to-end /metrics scrape over the real AdminMux with a store opened under per-level compression. Full suite passes, -race clean on touched packages, go.mod/go.sum unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wavesdb (the embedded LSM engine) gained 9 ondadb-backport features, already merged into wavesdb main which waveSpan builds against via the ../wavesdb replace directive. This wires the genuinely-additive ones into waveSpan's Go layers; the rest (RYOW fix, compaction filters, FIFO, ClearColumnFamily) are skipped because they duplicate or would break waveSpan's own distributed logic (documented inline).
Also fixes a latent bug this surfaced: empty-string tunable defaults rendered as YAML null in the reference generator (reference.go now quotes them).
Tests cover each workstream plus an end-to-end /metrics scrape over the real AdminMux with a store opened under per-level compression. Full suite passes, -race clean on touched packages, go.mod/go.sum unchanged.