This repository was archived by the owner on Apr 11, 2021. It is now read-only.
Auth#23
Merged
Merged
Conversation
- Remove some else statements using return. Just to make the code clearer.
Owner
|
Hi Brice, Thank you for your feature and refactoring ! By HTTP Auth I was thinking of securing BeePing API itself but it's still a very nice feature. I'll do some checks with #19 before merging but changes seems OK for me. Cheers, |
Owner
|
Thanks ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the HTTP Basic Auth support.
Make a very little refactoring, just remove some else statements using return instruction. Make the code a little clearer.