Conversation
xx4h
force-pushed
the
feat/improve-error-messages
branch
from
c867011 to
1e248c6
Compare
Replace the generic "no Entity X capable of Y" error with specific messages distinguishing: entity not found, domain not found, domain lacks service, and entity exists but wrong domain. Also add HTTP status code checking to the API client (401, 404, other non-200). When fuzzy matching is enabled, resolve the entity name against all states before producing error messages so that typos reference the matched entity rather than the raw input. Signed-off-by: Fabian 'xx4h' Sylvester <xx4h@xx4h.de>
xx4h
force-pushed
the
feat/improve-error-messages
branch
from
1e248c6 to
a367052
Compare
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the generic "no Entity X capable of Y" error with specific messages distinguishing: entity not found, domain not found, domain lacks service, and entity exists but wrong domain. Also add HTTP status code checking to the API client (401, 404, other non-200).
When fuzzy matching is enabled, resolve the entity name against all states before producing error messages so that typos reference the matched entity rather than the raw input.