Reduce dead code surface and decouple BadgerRoutinePage from BadgerEnvBox UI internals#264
Draft
Copilot wants to merge 7 commits into
Draft
Reduce dead code surface and decouple BadgerRoutinePage from BadgerEnvBox UI internals#264Copilot wants to merge 7 commits into
BadgerRoutinePage from BadgerEnvBox UI internals#264Copilot wants to merge 7 commits into
Conversation
…rmatting Agent-Logs-Url: https://github.com/xopt-org/Badger/sessions/f7f17161-ab60-47d5-8686-54d9f57a6b8d Co-authored-by: roussel-ryan <24279776+roussel-ryan@users.noreply.github.com>
Agent-Logs-Url: https://github.com/xopt-org/Badger/sessions/f7f17161-ab60-47d5-8686-54d9f57a6b8d Co-authored-by: roussel-ryan <24279776+roussel-ryan@users.noreply.github.com>
Agent-Logs-Url: https://github.com/xopt-org/Badger/sessions/f7f17161-ab60-47d5-8686-54d9f57a6b8d Co-authored-by: roussel-ryan <24279776+roussel-ryan@users.noreply.github.com>
Agent-Logs-Url: https://github.com/xopt-org/Badger/sessions/f7f17161-ab60-47d5-8686-54d9f57a6b8d Co-authored-by: roussel-ryan <24279776+roussel-ryan@users.noreply.github.com>
Agent-Logs-Url: https://github.com/xopt-org/Badger/sessions/f7f17161-ab60-47d5-8686-54d9f57a6b8d Co-authored-by: roussel-ryan <24279776+roussel-ryan@users.noreply.github.com>
Agent-Logs-Url: https://github.com/xopt-org/Badger/sessions/f7f17161-ab60-47d5-8686-54d9f57a6b8d Co-authored-by: roussel-ryan <24279776+roussel-ryan@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
roussel-ryan
May 14, 2026 21:30
View session
Collaborator
|
@copilot we should make sure that these changes do not modify the badger command line interface |
Agent-Logs-Url: https://github.com/xopt-org/Badger/sessions/8b056ff8-12f6-4f8c-ae5f-4da88ec82c94 Co-authored-by: roussel-ryan <24279776+roussel-ryan@users.noreply.github.com>
Author
Addressed in 516de55. I restored the deprecated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR trims several code spurs (unreachable deprecated paths, unused scaffolding, stale disabled tests) and reduces coupling in the GUI layer where
BadgerRoutinePagepreviously depended onBadgerEnvBoxinternal widgets. It also centralizes duplicated optimization formatting logic and tightens string-to-value parsing behavior.Deprecated CLI and unreachable-path cleanup
src/badger/actions/routine.pysrc/badger/actions/run.pysrc/badger/actions/install.pysrc/badger/actions/uninstall.pyrunargparse wiring insrc/badger/__main__.pysobadger run ...remains available and backward-compatible.Optimization logic deduplication
src/badger/optimization.py::convert_to_solution.src/badger/core.pysrc/badger/core_subprocess.pyRoutine page / env box disentangling
BadgerEnvBox(e.g.sig_add_random_requested,sig_refresh_requested,sig_environment_selected, etc.).BadgerRoutinePageto connect to those signals instead of binding directly toBadgerEnvBoxbutton/widget internals.BadgerRoutinePagenow depends on an action interface fromBadgerEnvBox, not its internal control graph.Code spur removal
src/badger/extension.pysrc/badger/factory.pysrc/badger/tests/x-test_db.pysrc/badger/tests/x-test_routine_id.pyParsing correctness
convert_str_to_valueinsrc/badger/utils.pyso boolean parsing is explicit ("true"/"false"), notbool(str)-based.src/badger/tests/test_utils.pyfor case variants, direct booleans, numeric strings, and non-convertible strings.