Fix TTY table emoji width for ZWJ and skin-tone sequences#34
Merged
Conversation
xenodium
approved these changes
May 24, 2026
Owner
|
Thanks for the PR! |
Contributor
Author
|
Thanks! FWIW the same TTY shaping fix would apply to the new renderer in xenodium/agent-shell#597 — its --table-needs-pixel-p covers ZWJ and regional-indicator pairs but not VS-16 or skin-tone modifiers, and it has no TTY path |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A small fix to ensure tty-only users also get nice emoji alignment :-)
Modern terminals (Ghostty, WezTerm, Kitty, iTerm2) shape ZWJ sequences and skin-tone modifiers into single 2-cell glyphs, but
string-widthsums their components — so tables with complex emoji misalign in TTY mode.This routes the TTY width and padding paths through a new
markdown-overlays--string-widththat splits into grapheme clusters and forces width 2 for ZWJ, VS-16, and Fitzpatrick modifiers.Terminal detection is a small
TERM_PROGRAMallowlist (Ghostty, WezTerm, Kitty, iTerm2), memoized on a frame parameter. Setting themarkdown-overlays-modern-ttyframe parameter toyesornooverrides the detection.Tests cover the grapheme-width rules and the allowlist/denylist behavior.