fix: MaruBackend test failures, config cleanup, close() drain#16
Merged
Conversation
Align with existing config pattern (max_local_cpu_size uses float GB). Remove _parse_pool_size string parser in favor of simple GB-to-bytes conversion. This eliminates silent fallback on invalid values.
Wait for all pending async store tasks to complete before closing the handler, consistent with PDBackend and GDSBackend patterns. Prevents crash/data loss when _async_store is still running.
jooho-XCENA
force-pushed
the
fix/maru-test-pin
branch
from
f150a95 to
947ab8a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pin_kv→pinrename missed in test_maru_backend.pymaru_pool_sizeconfig fromstr(e.g."4G") tofloatin GB (e.g.4.0), aligning withmax_local_cpu_sizepatternTest plan
pytest tests/v1/storage_backend/test_maru_backend.py— 49 passed, 0 failed (DAX not required)