docs: add strict bot policies (non-loop) + update trigger workflow#143
Merged
Conversation
- bot/BOT_POLICY.md: hard rules, non-loop merge policy (bot never merges) - bot/AUTHOR_POLICY.md: commit identity, PR process, code quality - bot/REVIEW_POLICY.md: strict checklist, reviewer schedule - bot/ENTRY.md: bot entry point - trigger-integration.yml: add pull_request trigger - Move old BOT_POLICY.md to bot/BOT_POLICY_LEGACY.md
hlin99-Review-Bot
approved these changes
Apr 6, 2026
hlin99-Review-Bot
left a comment
Collaborator
There was a problem hiding this comment.
LGTM. Reviewed all 6 changed files.
Summary:
bot/directory structure with split policies (BOT_POLICY, AUTHOR_POLICY, REVIEW_POLICY, ENTRY) is clean and well-organized.- Legacy BOT_POLICY.md correctly preserved as BOT_POLICY_LEGACY.md for reference.
- Workflow change: adding
pull_requesttrigger and switching toINTEGRATION_TOKENfor cross-repo dispatch is reasonable. The conditional logic for PR vs release events is correct. - No code changes, no security concerns, no test impact.
- CI all green (lint, test 3.10/3.11/3.12, build, trigger).
One note: bots currently reading BOT_POLICY.md from repo root will need to update their paths to bot/BOT_POLICY.md after this merges.
hlin99-Review-BotX
requested changes
Apr 6, 2026
hlin99-Review-BotX
left a comment
Collaborator
There was a problem hiding this comment.
hlin99-Review-BotX — reviewing commit 118a470
Issues Found
1. Broken reference: DESIGN_PRINCIPLES.md does not exist
bot/ENTRY.md(line 15) listsDESIGN_PRINCIPLES.mdas mandatory required reading (#4).bot/AUTHOR_POLICY.md(line 15) links to[DESIGN_PRINCIPLES.md](DESIGN_PRINCIPLES.md)for architecture constraints.bot/BOT_POLICY.md(line 49) links to[DESIGN_PRINCIPLES.md](DESIGN_PRINCIPLES.md).
This file is not included in the PR and does not exist on main. All three references are broken links. Either include the file in this PR or remove the references until it exists.
Everything else looks good
- Workflow change in
trigger-integration.ymlis clean: addspull_requesttrigger, switches toINTEGRATION_TOKEN(cross-repo dispatch needs a PAT, notGITHUB_TOKEN), and handles both event types correctly. - Policy split across
bot/BOT_POLICY.md,AUTHOR_POLICY.md,REVIEW_POLICY.md,ENTRY.mdis well-organized. - Legacy policy preserved as
bot/BOT_POLICY_LEGACY.md— good for reference. - Note: ensure existing bot crons that read root
BOT_POLICY.mdare updated to read frombot/after merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes: