refactor: remove integration/stress tests and sim_adapter#141
Conversation
hlin99
force-pushed
the
refactor/remove-integration-tests-v2
branch
from
6249ed5 to
c97b428
Compare
Migrated to xPyD-integration repo: - tests/integration/ (~115 tests) - tests/stress/ (~10 tests) Also removed: - sim_adapter.py (no longer needed) - tests/conftest.py (only used by integration tests) - xpyd-sim dev dependency - Fixed build job CI to run unit tests
hlin99
force-pushed
the
refactor/remove-integration-tests-v2
branch
from
c97b428 to
2522c43
Compare
hlin99-Review-Bot
left a comment
hlin99-Review-Bot
left a comment
There was a problem hiding this comment.
Lint CI is failing. tests/unit/test_metrics.py still has import pytest at line 3, but after removing the async integration tests from that file, pytest is no longer used directly — only unittest.TestCase remains. Ruff flags this as F401.
Please remove the unused import pytest from tests/unit/test_metrics.py so lint passes.
Minor note: the build job in ci.yml now installs pytest-asyncio for running unit tests only — if no async tests remain in tests/unit/, that dependency is unnecessary (not blocking, just a cleanup opportunity).
Everything else looks good: integration/stress test removal is clean, xpyd-sim dev dep removed, CI test matrix updated correctly, sim_adapter.py and conftest.py removed. Unit and build CI jobs pass.
| @@ -59,33 +59,3 @@ def test_track_request_lifecycle(self): | |||
| output = get_metrics().decode() | |||
| assert "proxy_active_requests 0.0" in output | |||
| assert "proxy_request_duration_seconds" in output | |||
There was a problem hiding this comment.
This import pytest is still present on the branch but is now unused (the async tests that needed it were removed below). Ruff catches this as F401, causing lint CI to fail. Please remove this import.
hlin99-Review-BotX
left a comment
hlin99-Review-BotX
left a comment
There was a problem hiding this comment.
LGTM. The unused import pytest in test_metrics.py is fixed, CI is all green. Removal of integration/stress tests, sim_adapter.py, conftest.py, and xpyd-sim dev dep is clean.
Minor nit (non-blocking): .github/workflows/ci.yml is missing a trailing newline on the last line, and the build job still installs pytest-asyncio — if no async tests remain under tests/unit/, that dep is unnecessary.
…141) Migrated to xPyD-integration repo: - tests/integration/ (~115 tests) - tests/stress/ (~10 tests) Also removed: - sim_adapter.py (no longer needed) - tests/conftest.py (only used by integration tests) - xpyd-sim dev dependency - Fixed build job CI to run unit tests Co-authored-by: hlin99 <hlin99@users.noreply.github.com>
…141) Migrated to xPyD-integration repo: - tests/integration/ (~115 tests) - tests/stress/ (~10 tests) Also removed: - sim_adapter.py (no longer needed) - tests/conftest.py (only used by integration tests) - xpyd-sim dev dependency - Fixed build job CI to run unit tests Co-authored-by: hlin99 <hlin99@users.noreply.github.com>
3 participants
Tests migrated to xPyD-integration. Remove integration/ + stress/ + sim_adapter.py + conftest + xpyd-sim dep. Fix build job CI.