feat: Benchmark Dataset Catalog (M120)#264
Merged
Merged
Conversation
- DatasetCatalog class in catalog.py with SQLite-backed storage - CatalogEntry, CatalogQuery, CatalogReport Pydantic models - SHA-256 file hash for duplicate detection - Metadata extraction: GPU type, model, P:D ratio, QPS, request count - Search by GPU type, QPS range, P:D ratio, model name, instance count - CLI catalog subcommand: add, list, search, show, remove - Programmatic manage_catalog() API - 23 new tests Closes #263
hlin99-Review-Bot
approved these changes
Apr 6, 2026
hlin99-Review-Bot
left a comment
Contributor
There was a problem hiding this comment.
✅ Approved by hlin99-Review-Bot
Idea Value: Strong. A SQLite-backed benchmark catalog is a natural next step — makes benchmark data discoverable and queryable instead of scattered files. Good alignment with the project's benchmarking infrastructure.
Code Quality:
- Clean SQLite schema with proper indexes for common query patterns
- SHA-256 duplicate detection ✓
- Comprehensive search with multiple filter dimensions
- CLI well-structured with Rich table output + JSON format option
- 23 tests covering add/remove/search/duplicates/edge cases ✓
docs/iterations/current.mdupdated ✓- CI all green (lint + tests on 3.10/3.11/3.12) ✓
LGTM 🚀
hlin99-Review-BotX
approved these changes
Apr 6, 2026
hlin99-Review-BotX
left a comment
There was a problem hiding this comment.
✅ Approved by hlin99-Review-BotX
Idea Value: Good fit. A local SQLite catalog for benchmark files is a natural extension — makes discovery and filtering straightforward without external dependencies.
Code Quality:
- Clean SQLite schema with proper indexes for gpu_type, pd_ratio, qps, date ✓
- SHA-256 duplicate detection ✓
- Pydantic models well-structured ✓
- Search supports multiple filter dimensions with proper parameterized queries ✓
- CLI with Rich table + JSON output ✓
- 23 tests ✓
docs/iterations/current.mdupdated ✓- CI all green (lint + tests 3.10/3.11/3.12) ✓
LGTM 🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a SQLite-backed local catalog for indexing and searching benchmark files.
Changes
DatasetCatalogclass incatalog.pywith SQLite storageCatalogEntry,CatalogQuery,CatalogReportPydantic modelscatalogsubcommand:add,list,search,show,removemanage_catalog()APIdocs/iterations/current.mdCloses #263