feat: TensorRT-LLM Benchmark Command Generator (M113)#250
Merged
Conversation
- TRTLLMCommandGenerator class in trtllm_commands.py - TRTLLMCommandConfig, TRTLLMServerCommand, TRTLLMBenchmarkCommand, TRTLLMCommandSet models - Generate trtllm-build engine and tensorrt_llm.serve commands for each P:D ratio - TRT-LLM options: max_batch_size, kv_cache_free_gpu_mem_fraction, pp_size, dtype, engine_dir - Shell script output with engine build + server + benchmark lifecycle - CLI trtllm-commands subcommand with table + JSON output - Programmatic generate_trtllm_commands() API - 29 new tests Closes #249
hlin99-Review-Bot
approved these changes
Apr 6, 2026
hlin99-Review-Bot
left a comment
Contributor
There was a problem hiding this comment.
✅ Approved by hlin99-Review-Bot
Idea Value: Good — completes the TRT-LLM toolchain (importer M112 + command generator M113), consistent with vLLM and SGLang patterns.
Code Quality:
- Clean Pydantic models (TRTLLMCommandConfig, TRTLLMServerCommand, TRTLLMBenchmarkCommand, TRTLLMCommandSet)
- Generator correctly produces engine build → server → benchmark → cleanup lifecycle
- CLI registration follows established pattern
- 29 tests, all passing
- docs/iterations/current.md and ROADMAP.md updated
- CI all green (lint + tests 3.10/3.11/3.12)
LGTM 🚀
hlin99-Review-BotX
approved these changes
Apr 6, 2026
hlin99-Review-BotX
left a comment
There was a problem hiding this comment.
✅ Approved by hlin99-Review-BotX
Idea Value: Good — M113 completes the TRT-LLM command generator, consistent with the vLLM (M109) and SGLang (M111) patterns. Aligns with roadmap.
Code Quality:
- Clean Pydantic models (TRTLLMCommandConfig, TRTLLMServerCommand, TRTLLMBenchmarkCommand, TRTLLMCommandSet)
- Generator correctly produces engine build → server → benchmark → cleanup lifecycle
- CLI registration follows established pattern (
register_trtllm_commands,_cmd_trtllm_commands) - Shell script generation with proper
set -euo pipefailand server PID management __init__.pyexports and__all__updated correctly- ROADMAP.md and docs/iterations/current.md updated
- 29 tests, CI all green (lint + tests 3.10/3.11/3.12)
LGTM 🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TensorRT-LLM Benchmark Command Generator — generate ready-to-run TRT-LLM engine build, server launch, and benchmark commands for P:D ratio exploration.
Mirrors the existing vLLM and SGLang command generators.
Changes
TRTLLMCommandGeneratorclass intrtllm_commands.pyTRTLLMCommandConfig,TRTLLMServerCommand,TRTLLMBenchmarkCommand,TRTLLMCommandSetPydantic modelstrtllm-buildengine build +tensorrt_llm.serveserver +trtllm-benchbenchmarktrtllm-commandssubcommand with table + JSON + --output-scriptgenerate_trtllm_commands()APICloses #249