Skip to content

[Chore] Pass around boom module as settings#100

Draft
joaquinco wants to merge 1 commit intowyeworks:masterfrom
joaquinco:chore/handle-settings-by-module
Draft

[Chore] Pass around boom module as settings#100
joaquinco wants to merge 1 commit intowyeworks:masterfrom
joaquinco:chore/handle-settings-by-module

Conversation

@joaquinco
Copy link
Contributor

@joaquinco joaquinco commented Sep 20, 2024 •
edited
Loading

Allow to call notfy_error(settings, conn, error) by specifying a settings Keyword or module where BoomNotifier has been used. This can be more efficient in some cases where the NotificationSender genserver schedules notification sending specifying settings and error_info.

Also

  • Make notifier :options configuration entry optional
  • Cleanup NotificationSender public API to just trigger_notify/2 and async_trigger_notify/2

@joaquinco joaquinco changed the title [Chore] Pass around settings by specifying boom module [Chore] Pass around settings as boom module Sep 20, 2024
@joaquinco joaquinco changed the title [Chore] Pass around settings as boom module [Chore] Pass around boom module as settings Sep 20, 2024
@joaquinco joaquinco force-pushed the chore/handle-settings-by-module branch from 1be6c5d to 5fe29a2 Compare November 20, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@joaquinco