Validate the options for expect_request!#19
Merged
fatboypunk merged 1 commit intomainfrom Jun 3, 2025
Merged
Conversation
Because:
When you enter `expected_body: {some_json, :json},` and the tests
succeed you might think you've tested the proper json is send. But
because this option isn't used that's not the case. So to guard against
that we're now checking if the option that's given will actually be
used, rather then ignore it the test will now raise.
Kociamber
approved these changes
May 27, 2025
Pull Request Test Coverage Report for Build aca591302fc71c54d8019ad3464c409d4b98fea8-PR-19Details
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because:
When you enter
expected_body: {some_json, :json},and the tests succeed you might think you've tested the proper json is send. But because this option isn't used that's not the case. So to guard against that we're now checking if the option that's given will actually be used, rather then ignore it the test will now raise.