This repository was archived by the owner on Feb 16, 2022. It is now read-only.
Not use react-dom + input tag name#9
Open
hasnat wants to merge 3 commits into
Open
Conversation
Contributor
Author
|
ping @wubocong |
|
Would love to see this merged, will use your fork for now. Cheers |
Contributor
Author
|
Yea, You can use https://www.npmjs.com/package/@hasnat/react-upload-file for now. |
Contributor
Author
|
Added another commit which adds optional prop |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was going to add react-dom to webpack external, but we don't need react-dom its only being used to findNode to set as input, which I have changed to ref as a method for same input.
This brings down dist min file from 230kb to 7kb (not gzipped)