feat(logging): Enable conditional logging based on --logger flag using dynamic Pino config#89
Open
feat(logging): Enable conditional logging based on --logger flag using dynamic Pino config#89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces changes to enhance the configurability of the
HubBackendandTestAutomationmodules, particularly by adding support for enabling or disabling logging through a newloggeroption. It also refactors how options are handled and passed between components to improve flexibility and maintainability.Enhancements to
HubBackend:loggeroption to theopenmethod ofHubBackend, allowing conditional activation of logging and global exception filters. [1] [2]src/HubBackend.tsto includeTestAutomation, enabling integration with the new options.Updates to
TestAutomation:loggerproperty in theTestAutomation.IOptionsinterface to enable or disable logging during test automation.getOptionsfunction intest/TestAutomation.tsto parse and handle the newloggeroption from the command line. [1] [2]Refactoring in
test/index.ts:openmethod in theIBackendinterface and its implementation to accept theTestAutomation.IOptionsobject, ensuring consistent option handling across components. [1] [2]