codegen: frexp, mod, switch-case#52
Conversation
| @@ -0,0 +1,5 @@ | |||
| void main() { | |||
There was a problem hiding this comment.
@r4nd0mus3rnam3 can you add tests similar to the other CodeGen tests, i.e. using FileCheck?
| @@ -0,0 +1,15 @@ | |||
| void main() { | |||
There was a problem hiding this comment.
Same here, can you please use FileCheck?
|
@r4nd0mus3rnam3 Left 2 comments, also, tests are failing but it looks like it was just a timeout because it started rebuilding LLVM in the CI. |
wpmed92
changed the title
|
i was getting some issues with compilation for the switch case op. this shouldn't affect compilation however; i was able to get it to compile fine when i commented out that line. i will add the proper test for mod soon. the switch case test i will need to look into further since i haven't completed the implementation of switch case. |
|
i have added changes to the test cases to match the other test cases. i have not checked for full correctness yet. with regard to the llvm commit comment, i think the current commit in the repository is outdated, as i don't believe it has the spirv switch op, since i could not get it to compile with the switch op. i may however be mistaken. |
|
@r4nd0mus3rnam3 can you update the llvm commit in the repo to the one you use locally? |
|
i am unsure how to do this, as i haven't updated the llvm submodule on my fork. i think a more recent release should work however. |
|
i have updated the submodule, but have not tested it against shaderpulse yet. |
2 participants
working on codebase. upstreaming small changes for now. will likely rework most of these additions later.