Skip to content

feat!: require workos-php v7#103

Open
gjtorikian wants to merge 2 commits into
mainfrom
deps/allow-workos-php-v7
Open

feat!: require workos-php v7#103
gjtorikian wants to merge 2 commits into
mainfrom
deps/allow-workos-php-v7

Conversation

@gjtorikian

@gjtorikian gjtorikian commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Closes #102.

The workos-php package was released, but was not reflected here.

BREAKING CHANGE: drops support for workos-php v6. v7 moved the Vault service from \WorkOS\Vault to \WorkOS\Service\Vault, a breaking change that no single class reference can satisfy across both majors, so the constraint is narrowed to ^7.0.1 and the service-provider test asserts against the new namespace.

@gjtorikian gjtorikian requested review from a team as code owners June 17, 2026 16:11
@gjtorikian gjtorikian requested a review from mattgd June 17, 2026 16:11

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 1 additional finding.

Open in Devin Review

@greptile-apps

greptile-apps Bot commented Jun 17, 2026

Copy link
Copy Markdown

Greptile Summary

This PR bumps the workos/workos-php dependency constraint from ^6.0.0 to ^7.0.1 and updates the corresponding test to match a namespace change introduced in v7 (\WorkOS\Vault\WorkOS\Service\Vault).

  • composer.json: Constraint updated to ^7.0.1, which will allow v7.0.1 and all future semver-compatible v7 releases while excluding v7.0.0.
  • WorkOSServiceProviderTest.php: The vault() service assertion is corrected to \WorkOS\Service\Vault::class to match the new namespace location in the upstream v7 package.

Confidence Score: 5/5

Safe to merge — the change is a minimal dependency bump with a matching test correction.

Both changes are tightly scoped: the composer constraint update pins to the newly released v7.0.1+ line, and the test fix corrects the fully-qualified class name for Vault to match where it now lives in the upstream package. No application logic is touched.

No files require special attention.

Important Files Changed

Filename Overview
composer.json Bumps workos/workos-php constraint from ^6.0.0 to ^7.0.1 to support the newly released v7 package.
tests/WorkOS/WorkOSServiceProviderTest.php Updates vault() assertion namespace from \WorkOS\Vault to \WorkOS\Service\Vault, reflecting the class move in workos-php v7.

Sequence Diagram

%%{init: {'theme': 'neutral'}}%%
sequenceDiagram
    participant Laravel as Laravel App
    participant Provider as WorkOSServiceProvider
    participant WorkOS as workos/workos-php v7
    participant Vault as WorkOS\Service\Vault

    Laravel->>Provider: boot()
    Provider->>WorkOS: new WorkOS(apiKey, clientId, ...)
    WorkOS-->>Provider: $client
    Provider->>Laravel: bind('workos', $client)
    Laravel->>WorkOS: "$client->vault()"
    WorkOS->>Vault: new Service\Vault(...)
    Vault-->>Laravel: \WorkOS\Service\Vault instance
Loading
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
sequenceDiagram
    participant Laravel as Laravel App
    participant Provider as WorkOSServiceProvider
    participant WorkOS as workos/workos-php v7
    participant Vault as WorkOS\Service\Vault

    Laravel->>Provider: boot()
    Provider->>WorkOS: new WorkOS(apiKey, clientId, ...)
    WorkOS-->>Provider: $client
    Provider->>Laravel: bind('workos', $client)
    Laravel->>WorkOS: "$client->vault()"
    WorkOS->>Vault: new Service\Vault(...)
    Vault-->>Laravel: \WorkOS\Service\Vault instance
Loading

Reviews (2): Last reviewed commit: "fix: require workos-php v7 and update Va..." | Re-trigger Greptile

Drop v6 support since v7 moved the Vault service from \WorkOS\Vault to
\WorkOS\Service\Vault, a breaking change that no single class reference
can satisfy across both majors. Update the service-provider test to
assert against the new namespace.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@gjtorikian gjtorikian changed the title fix: Support v7.0.1+ feat!: require workos-php v7 Jun 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Broken authentication

1 participant