chore(deps): update nuget dependencies to v18 (major)#162
Open
Gérald Barré (geraldbarre-workleap) wants to merge 2 commits intomainfrom
Open
chore(deps): update nuget dependencies to v18 (major)#162Gérald Barré (geraldbarre-workleap) wants to merge 2 commits intomainfrom
Gérald Barré (geraldbarre-workleap) wants to merge 2 commits intomainfrom
Conversation
Microsoft.Build.* v18 packages no longer include net8.0 runtime assemblies, only net10.0 and net472. This change: - Updates all test projects from net8.0 to net10.0 - Updates Microsoft.Build.Utilities.Core to v18.0.2 in the main project - Updates CI workflow to use global.json for SDK version Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Gérald Barré (geraldbarre-workleap)
requested a review
from a team
as a code owner
Gérald Barré (geraldbarre-workleap)
temporarily deployed
to
ci
GitHub Actions
Inactive
Copilot started reviewing on behalf of
Gérald Barré (geraldbarre-workleap)
February 3, 2026 16:36
View session
Gérald Barré (geraldbarre-workleap)
temporarily deployed
to
ci
GitHub Actions
Inactive
There was a problem hiding this comment.
Pull request overview
This PR upgrades Microsoft.Build dependencies from v17 to v18, which is a major version update that requires migrating all test and web projects from .NET 8.0 to .NET 10.0. This is necessary because Microsoft.Build v18 packages no longer support net8.0 runtime assemblies and only support net10.0 and net472.
Changes:
- Updated Microsoft.Build.Framework and Microsoft.Build.Utilities.Core from 17.10.46 to 18.0.2
- Updated Microsoft.NET.Test.Sdk from 17.14.1 to 18.0.1
- Migrated all test and web projects from net8.0 to net10.0 target framework
- Updated CI workflow to use global.json instead of hardcoded .NET version
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/Workleap.OpenApi.MSBuild/Workleap.OpenApi.MSBuild.csproj | Updated Microsoft.Build.Utilities.Core to 18.0.2 |
| src/tests/Workleap.OpenApi.MSBuild.Tests/Workleap.OpenApi.MSBuild.Tests.csproj | Updated target framework to net10.0 and upgraded test SDK packages to v18 |
| src/tests/WebApi.MsBuild.SystemTest.GenericTest/WebApi.MsBuild.SystemTest.GenericTest.csproj | Updated target framework to net10.0 |
| src/tests/WebApi.MsBuild.SystemTest.OasDiffError/WebApi.MsBuild.SystemTest.OasDiffError.csproj | Updated target framework to net10.0 |
| src/tests/WebApi.MsBuild.SystemTest.SpectralError/WebApi.MsBuild.SystemTest.SpectralError.csproj | Updated target framework to net10.0 |
| src/WebApiDebugger/WebApiDebugger.csproj | Updated target framework to net10.0 |
| .github/workflows/ci.yaml | Changed from hardcoded dotnet-version to using global.json file |
Gérald Barré (geraldbarre-workleap)
temporarily deployed
to
ci
GitHub Actions
Inactive
Gérald Barré (geraldbarre-workleap)
temporarily deployed
to
ci
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
17.10.46→18.0.217.10.46→18.0.217.14.1→18.0.1Additional changes to fix CI
The
Microsoft.Build.*v18 packages no longer includenet8.0runtime assemblies - they only supportnet10.0andnet472. This PR includes the following additional changes to fix the CI:net8.0tonet10.0Microsoft.Build.Utilities.Corein the main project to18.0.2global-json-file: global.jsoninstead of hardcodeddotnet-version: "8.0.x"These changes ensure compatibility with the new Microsoft.Build v18 packages.
🤖 Generated with Claude Code