Implement GutenbergKitResources binary dependency build #318
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| #!/usr/bin/env bash | ||
|
|
||
| set -euo pipefail | ||
|
|
||
| version="$1" | ||
|
|
||
| if [[ -z "$version" ]]; then | ||
| echo "Error: version argument is required" | ||
| exit 1 | ||
| fi | ||
|
|
||
| echo "--- :robot_face: Use bot for Git operations" | ||
| source use-bot-for-git | ||
|
|
||
| echo "--- :rubygems: Installing gems" | ||
| install_gems | ||
|
|
||
| echo "--- :xcode: Building XCFramework" | ||
| make build-resources-xcframework REFRESH_L10N=1 REFRESH_JS_BUILD=1 | ||
|
Member
There was a problem hiding this comment. Similar to my comment on the Buildkite configuration, should/can we reuse the JavaScript build artifact?
Member
There was a problem hiding this comment. Struggling to understand how these XCFramework releases coincide/integrate with GutenbergKit releases. The existing release script for the latter bumps the version for inclusion in the JavaScript, so that accurate version numbers are reported in exceptions. Should the XCFramework and GutenbergKit versions align? Maybe that is only required for tagged GutenbergKit releases, and XCFramework releases for Git commits can simply use the last tagged version string? I had Claude capture the issue and potential solution in its own words below as well. I'm remain uncertain as to the current state, plan, or appropriate solution. WDYT?
Contributor
Author
There was a problem hiding this comment. Thanks for this @dcalhoun . To be honest, I'm still unsure about how to proceed, too. So far, I've just tried to mimic the wordpress-rs behavior to have CI track the checksum and revision in the You bring up a good point regarding the version bump. It's frustrating that there's no way to do a version bump and I'll have to think about this... |
||
|
|
||
| echo "--- :rocket: Publishing release $version" | ||
| bundle exec fastlane release "version:$version" | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| --- | ||
| BUNDLE_PATH: "vendor/bundle" | ||
| BUNDLE_SPECIFIC_PLATFORM: "false" | ||
| BUNDLE_FORCE_RUBY_PLATFORM: "true" |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| # frozen_string_literal: true | ||
|
|
||
| source 'https://rubygems.org' | ||
|
|
||
| gem 'fastlane', '~> 2.230' | ||
| gem 'fastlane-plugin-wpmreleasetoolkit', '~> 13.8' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After #320, we now cache the JavaScript build as an artifact to improve speed and mitigate 429 errors for translation downloads. Can we reuse that artifact for this job?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For sure!
https://linear.app/a8c/issue/AINFRA-2159/resue-cached-js-in-ci