Completed translations for pt-PT locate + minor fix in en-US#1145
Conversation
…t-PT.json) translation file Portuguese locale added to SupportedLocales.ts Minor bugfix line 2359 of en-us.json where "last" object documentation referred to .first() instead. '$~' removed from edited translations.
amyjko
left a comment
amyjko
left a comment
There was a problem hiding this comment.
Wonderful, thank you so much for this comprehensive review!
While you were working on it, we changed the template syntax to use named parameters (e.g., $first, $second) instead of numbered parameters (e.g., $1, `$2). That led to some conflicts. Can you review the conflicts and make sure that the named parameters end up in the right place in the text? It should be relatively quick scan to verify.
After the conflicts are resolved, I think this is ready to ship.
minor spelling change
|
Sounds good, I've reviewed the conflicts and integrated my translation fixes where needed to reflect my previous changes with the new syntax, and reviewed the new additional lines in the file. |
amyjko
left a comment
amyjko
left a comment
There was a problem hiding this comment.
One last question here: many strings still start with $~, meaning they are still annotated as machine translated. Or those strings you didn't review, or did you review them and those annotations should be removed? (If you reviewed everything, we should remove all of them, except for the newest strings that I just added to this PR). You could do a simple search and replace if they're all reviewed.
|
I did review everything, will do! |
Removed $~ from all translations as they were reviewed
|
Alright, I removed the $~ and resolved the new merge conflicts, reviewing the new lines. |
amyjko
left a comment
amyjko
left a comment
There was a problem hiding this comment.
Looks good to go! I will merge and get it live. Thank you so much for the thorough contribution!
3 participants
Context
Completed portuguese-portugal translations in both tutorial (pt-PT-tutorial.json) and base (pt-PT.json) translation files
Portuguese locale added to SupportedLocales.ts
Minor bugfix line 2359 of en-us.json where "last" object documentation referred to .first() instead.
Fixed formatting issues caused by machine translation within translation text (largely missing spaces, special characters).
Verification
Line-by-line verification of translations, consultation with Portuguese dictionary (priberam.org; utilized by university of lisbon), for verification of vocabulary suitable for the locale.
Selecting established vocabulary for programming concepts by referencing existing translated documentation for programming languages
Verification that the tone and vocabulary used match the context, particularly for shorter translations where words with multiple meanings are frequently mistranslated in context.