[bugfix] fix canary support for functions with ASM inline#9
Merged
PThierry merged 1 commit intowookey-project:masterfrom Mar 6, 2020
Merged
[bugfix] fix canary support for functions with ASM inline#9PThierry merged 1 commit intowookey-project:masterfrom
PThierry merged 1 commit intowookey-project:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Canaries with recent versions of gcc (>= 8) are not handled by _s_tack_check_fails() when gcc compiles functions with ASM inline in it (typically syscalls backend).
For those specific functions, canaries must be deactivated to avoid canary invalid construction.
INFO: this PR is a cherry-picking of PR #5 which handle this feature and allocator hardening in the same time. For this last PR, a clean rebase must first be done now that the new memory handling mechanism has been merged upstream.