Skip to content

Attempt wolfssl_read_bio_file in read_bio even when XFSEEK is available#8703

Merged
dgarske merged 3 commits intowolfSSL:masterfrom
lealem47:zd19592
May 6, 2025
Merged

Attempt wolfssl_read_bio_file in read_bio even when XFSEEK is available#8703
dgarske merged 3 commits intowolfSSL:masterfrom
lealem47:zd19592

Conversation

@lealem47
Copy link
Copy Markdown
Contributor

Description

Some changes required for wolfSSL/wolfCLU#178.

  • First commit enhances wolfSSL_BIO_Read() to account for BIO's created with symlink files that aren't fseek-able (for eg. /proc/self/fd/0)
  • Second commit removes the PKCS8 header check in wc_CreatePKCS8Key() when WOLFSSL_NO_ASN_STRICT is defined for cases where an existing PKCS8 key is being created in place in the same BIO via the wolfSSL_d2i_PrivateKey_bio() API

Fixes zd#19592

Testing

Testing done with wolfCLU

Checklist

  • added tests
  • updated/added doxygen
  • updated appropriate READMEs
  • Updated manual and documentation

@lealem47
Copy link
Copy Markdown
Contributor Author

Jenkins Retest this please

@lealem47 lealem47 self-assigned this Apr 23, 2025
@lealem47 lealem47 assigned wolfSSL-Bot and unassigned lealem47 May 5, 2025
@lealem47 lealem47 removed their assignment May 6, 2025
@lealem47 lealem47 requested a review from dgarske May 6, 2025 19:40
@dgarske
Copy link
Copy Markdown
Contributor

dgarske commented May 6, 2025

Retest this please: "Found unhandled org.jenkinsci.plugins.workflow.support.steps.AgentOfflineException exception:"

@dgarske dgarske merged commit 05a3557 into wolfSSL:master May 6, 2025
187 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants