Skip to content

Add sz check to ChachaAEADDecrypt to prevent potential underflow. #10125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kareem-wolfssl wants to merge 1 commit into
base: master
Choose a base branch
from
+6 −1
Open

Add sz check to ChachaAEADDecrypt to prevent potential underflow. #10125

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/internal.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20000,10 +20000,15 @@ int ChachaAEADDecrypt(WOLFSSL* ssl, byte* plain, const byte* input,
byte tag[POLY1305_AUTH_SZ];
byte poly[CHACHA20_256_KEY_SIZE]; /* generated key for mac */
int ret = 0;
int msgLen = (sz - ssl->specs.aead_mac_size);
int msgLen = 0;
Keys* keys = &ssl->keys;
byte* seq = NULL;

if (sz < ssl->specs.aead_mac_size) {
return BAD_FUNC_ARG;
}
msgLen = (sz - ssl->specs.aead_mac_size);

#ifdef CHACHA_AEAD_TEST
int i;
printf("input before decrypt :\n");
Expand Down
Loading