Skip to content

Fixes for wolfclu#10064

Open
julek-wolfssl wants to merge 3 commits intowolfSSL:masterfrom
julek-wolfssl:master
Open

Fixes for wolfclu#10064
julek-wolfssl wants to merge 3 commits intowolfSSL:masterfrom
julek-wolfssl:master

Conversation

@julek-wolfssl
Copy link
Copy Markdown
Member

@julek-wolfssl julek-wolfssl commented Mar 24, 2026

  • wc_EncryptedInfoGet: add AES-CTR support
  • Fix type casting for psk_keySz in MakePSKPreMasterSecret and initialize newSz in PKCS12_ConcatenateContent
  • Fix namespace collision on CRL reasons

@julek-wolfssl julek-wolfssl self-assigned this Mar 24, 2026
Copilot AI review requested due to automatic review settings March 24, 2026 18:52
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Renames CRL revocation reason enumerators to avoid global namespace collisions, updating OCSP responder logic, examples, and tests accordingly.

Changes:

  • Renamed CRL_REASON_* enumerators to WC_CRL_REASON_* in the public ASN/OCSP header.
  • Updated OCSP responder validation logic to use the renamed enumerators.
  • Updated OCSP responder example and API tests to compile against the new names.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
wolfssl/wolfcrypt/asn.h Renames CRL reason enumerators to WC_CRL_REASON_* to prevent symbol collisions.
src/ocsp.c Updates revocation reason bounds checking to use the renamed enumerators.
examples/ocsp_responder/ocsp_responder.c Updates example default revocation reason to the renamed enumerator.
tests/api/test_ocsp.c Updates OCSP tests to use the renamed revocation reason enumerators.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@julek-wolfssl julek-wolfssl changed the title Fix namespace collision on CRL reasons Fixes for wolfclu Apr 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants