Add the cleanup path and validations of XFSEEK and XFTELL#217
Closed
yosuke-wolfssl wants to merge 1 commit intowolfSSL:mainfrom
Closed
Add the cleanup path and validations of XFSEEK and XFTELL#217yosuke-wolfssl wants to merge 1 commit intowolfSSL:mainfrom
yosuke-wolfssl wants to merge 1 commit intowolfSSL:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR improves robustness of the signing input-file read path by adding explicit cleanup for the input file handle and buffer, and by validating XFSEEK/XFTELL results before proceeding.
Changes:
- Initialize locals and add a unified
cleanup:path to ensureXFCLOSE/XFREEare always executed on error. - Check
XFSEEKreturn value when seeking to end-of-file and back to start. - Validate the
XFTELL-derived file size before allocating and reading.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the cleanup path of file descriptor 'f' and the allocated memory 'data' explicitly. (f1484)
Also, this evaluates the return value of XFSEEK and XFTELL before using it.