Release v0.6.11: route non-MCP remote tasklist providers correctly#98
Merged
Conversation
Three orchestrator code paths special-cased MCPTasklistProvider and silently fell through to the local-file path for every other provider, breaking the beads backend (added in v0.6.10) and any future non-MCP remote provider. Fixes: - has_remaining_tasks() now queries any non-file provider directly instead of reading the local tasklist file. Beads users no longer see "NO MORE TASKS" while bd ready shows open work. - preflight_checks() no longer requires .millstone/tasklist.md for remote backends. Only FileTasklistProvider needs the local file. - Task selection prefers provider.list_ready_tasks() when the provider implements ReadyAwareTasklistProvider (beads), so blocked tasks are skipped instead of being shipped to the builder and bouncing as TASK_IMPOSSIBLE. Also: corrected the BeadsTasklistProvider / BeadsOpportunityProvider docstring config example to show flat top-level TOML keys (load_config() reads the top level only — the previous [millstone] table example was silently ignored). Adds tests/unit/test_remote_provider_routing.py with 6 regression tests. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes three orchestrator code paths that special-cased
MCPTasklistProviderand silently fell through to local-file behavior for every other provider — broke thebeadsbackend introduced in v0.6.10 (and would break any future non-MCP remote provider). Also fixes a docstring/config mismatch inbeads.py.Bugs fixed
has_remaining_tasks()ignored non-MCP providers (orchestrator.py~L845). With beads, millstone reportedNO MORE TASKSeven whenbd readyshowed open issues..millstone/tasklist.mdfor non-MCP providers (orchestrator.py~L1573). Beads users had totoucha stub file.list_tasks()fallback) (orchestrator.py~L3905, L3963). Result: builder got blocked tasks; reviewer halted withTASK_IMPOSSIBLE. Now prefersprovider.list_ready_tasks()when the provider implementsReadyAwareTasklistProvider(beads); falls back to status-filteredlist_tasks()for MCP/legacy.[millstone]table (beads.py) butload_config()only reads top-level keys — the previous example was silently ignored. Updated to flat top-level form.The fixes invert the dispatch:
FileTasklistProvideris the only special case, every other provider is routed to its own methods.New tests
tests/unit/test_remote_provider_routing.py— 6 regression tests covering all three bugs and the protocol wiring.Verification
millstone --max-tasks 1 --dry-runnow succeeds against a beads-only repo with no stub file.ruff check,ruff format,mypy,vulture, pre-commitlocal CI subsetall green.Test plan
has_remaining_tasksqueries provider for beads)list_ready_tasksto skip blocked)🤖 Generated with Claude Code