mcount: Fix segfault on GCC7#2
Open
withgit-contributor wants to merge 1 commit intowith-git:masterfrom
Open
Conversation
Taeung reported that uftrace crashed with segfault when it's built by GCC 7.x. This was because gcc saves %xmm register on function prologue using movaps but stack was not aglined in 16-byte boundary. It should be aligned otherwise CPU generates an exception (see below link): http://x86.renejeschke.de/html/file_module_x86_id_180.html Fixes with-git#1. Signed-off-by: withgit-contributor <withgit.contributor@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Taeung reported that uftrace crashed with segfault when it's built by
GCC 7.x. This was because gcc saves %xmm register on function prologue
using movaps but stack was not aglined in 16-byte boundary. It should
be aligned otherwise CPU generates an exception (see below link):
http://x86.renejeschke.de/html/file_module_x86_id_180.html
Fixes #1.
Signed-off-by: withgit-contributor withgit.contributor@gmail.com