Conversation
People were confused and loading it together with code-mode
There was a problem hiding this comment.
Pull request overview
This PR removes the standalone xlsx-verify skill to reduce confusion when users load it alongside xlsx-code-mode, and updates the examples/docs to rely on xlsx-code-mode for verification workflows.
Changes:
- Delete
skills/xlsx-verify/SKILL.md. - Update the verify example to load
skills/xlsx-code-mode/SKILL.mdinstead. - Remove/adjust documentation that referenced
xlsx-verify.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| skills/xlsx-verify/SKILL.md | Removes the standalone verify skill prompt markdown. |
| examples/verify.ts | Loads xlsx-code-mode skill instead of xlsx-verify. |
| examples/lib/buggy-workbook.ts | Updates doc comment to remove xlsx-verify reference. |
| examples/README.md | Removes xlsx-verify from the skills list and rewrites the verify section to reference xlsx-code-mode. |
| examples/AGENTS.md | Updates the verify entry point description to reference xlsx-code-mode. |
| CHANGELOG.md | Removes the xlsx-verify entry under Skills. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| // Load the xlsx-code-mode skill (includes lint, calc, render for verification) | ||
| const verifyPath = path.resolve(import.meta.dirname, '../skills/xlsx-code-mode/SKILL.md'); |
There was a problem hiding this comment.
xlsx-code-mode SKILL.md doesn’t document the witan xlsx calc --verify / witan xlsx lint verification workflow (it primarily documents exec, render, and an xlsx.lint(...) API). This comment + skill loading change may cause the verify example to miss the intended verification steps unless the prompt explicitly instructs the agent how to run verification. Consider either (a) updating skills/xlsx-code-mode/SKILL.md to include the verification gate and the calc --verify/lint CLI commands, or (b) adjusting this comment (and the prompt assembled in this script) to match the capabilities/instructions actually present in xlsx-code-mode.
| @@ -126,21 +124,6 @@ libraries or manual inspection can catch: | |||
| - **`witan xlsx render`** — renders any cell range as a PNG image so the | |||
There was a problem hiding this comment.
This section claims the xlsx-code-mode skill includes the verification tools as the standalone CLI commands witan xlsx lint and witan xlsx calc --verify, but skills/xlsx-code-mode/SKILL.md doesn’t document either of those commands/flags (and doesn’t mention --verify at all). To avoid confusing users, either update the skill prompt to explicitly include those verification commands/flags, or change this text to describe the verification approach the skill actually documents (e.g., using xlsx.lint(...) via witan xlsx exec, and whatever calc flow is intended).
| inspection) — tools that catch bugs invisible to normal spreadsheet use. | ||
| Combine with any write tooling to create an edit-verify loop. |
There was a problem hiding this comment.
skills/xlsx-code-mode/SKILL.md does not currently describe the same verification workflow that xlsx-verify documented (notably witan xlsx calc --verify and the standalone witan xlsx lint command). Since this file now states the verify entry point relies on xlsx-code-mode for lint/calc/render, consider adding a brief note here (or in the verify prompt) about how verification should be executed with xlsx-code-mode to prevent the example from regressing.
| inspection) — tools that catch bugs invisible to normal spreadsheet use. | |
| Combine with any write tooling to create an edit-verify loop. | |
| inspection) — the same verification building blocks used by `witan xlsx calc | |
| --verify` and `witan xlsx lint` to catch bugs invisible to normal spreadsheet | |
| use. In this example, the agent invokes these lint/calc/render tools to drive | |
| verification; combine them with any write tooling to create an edit–verify loop. |
People were confused and loading it together with code-mode