Conversation
LePailleurThibault
force-pushed
the
feature/img_interface
branch
from
216b16a to
c6f2531
Compare
wirepas_mqtt_library/topic_helper.py
Outdated
| return TopicGenerator._make_topic(BASE_IMG_RESPONSE, cmd, params) | ||
|
|
||
| @staticmethod | ||
| def make_img_set_config_response_topic(gw_id="+", sub_config="+"): |
There was a problem hiding this comment.
This looks like a weird value for gw_id 
There was a problem hiding this comment.
😅
Well it's part of the topic, it's not on me
examples/example_img_upload_image.py
Outdated
| logging.info("Upload img image in the MQTT broker") | ||
| wni.upload_img_image(args.image_id, image_binary.read(), chunk_size=args.chunk_size, app_version=args.app_version) | ||
|
|
||
| sleep(2) |
There was a problem hiding this comment.
i don't want the script to exit before sending the message to the MQTT broker
| 1) | ||
| return self._wait_for_response(cb, request.req_id, param=param) | ||
|
|
||
| def upload_img_image(self, image_id, image_binary, chunk_size, app_version, differential_image=False): |
There was a problem hiding this comment.
Is there a maximum chunk size for the IMG ?
If so it could be good to add an error if the limit is reached ? WDYT ?
There was a problem hiding this comment.
I don't know, but if there is, it must be MQTT broker dependant.
GwendalRaoul
left a comment
GwendalRaoul
left a comment
There was a problem hiding this comment.
To me it doesn't make sense to add it to wirepas_network_interface.py.
The only common part is that it uses a mqtt connection.
It could stay in same library but please make a dedicated interface.
wirepas_gateway_management_interface.py ?
wirepas_network_interface will be too huge with everything bundled.
LePailleurThibault
force-pushed
the
feature/img_interface
branch
from
633ae1d to
1c5d5f4
Compare
3 participants
No description provided.