fix(webapp): Implement recovery mechanism for epoch number mismatch between CC and local state [WPB-23452]#20508
Open
thisisamir98 wants to merge 7 commits intodevfrom
Open
fix(webapp): Implement recovery mechanism for epoch number mismatch between CC and local state [WPB-23452]#20508thisisamir98 wants to merge 7 commits intodevfrom
thisisamir98 wants to merge 7 commits intodevfrom
Conversation
…etween CC and local state [WPB-23452]
thisisamir98
requested review from
V-Gira,
arjita-mitra,
e-maad,
mathias-niboulies,
nkaramarko,
otto-the-bot,
screendriver and
zskhan
as code owners
Collaborator
screendriver
left a comment
screendriver
left a comment
There was a problem hiding this comment.
Shouldn't some tests fail now?
apps/webapp/src/script/repositories/conversation/ConversationRepository.ts
Show resolved
Hide resolved
apps/webapp/src/script/repositories/conversation/ConversationRepository.ts
Outdated
Show resolved
Hide resolved
…epository.ts Co-authored-by: Christian Rackerseder <git@echooff.de>
Contributor
|
🔗 Download Full Report Artifact 🧪 Playwright Test Summary
specs/CriticalFlow/backupRestoration-TC-8634.spec.ts (❌ 1 failed,
|
|
typfel
approved these changes
Feb 25, 2026
screendriver
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
if we read the epoch number from core crypto in case welcome is processed sooner than reset conversation will exists on core crypto but epoch number will be 0, on this scenario user will have a local unestablished MLS conversation
Solution:
In order to fix this we should not rely on the epoch number that we have on our local state and always read the epoch number from core crypto.